erc 721 coin instance page #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
approved these changes
Sep 3, 2019
apps/block_scout_web/lib/block_scout_web/controllers/tokens/instance_controller.ex
Outdated
Show resolved
Hide resolved
apps/block_scout_web/lib/block_scout_web/controllers/tokens/instance_controller.ex
Outdated
Show resolved
Hide resolved
vbaranov
requested changes
Sep 3, 2019
There was a problem hiding this comment.
- A user clicks to the id of NFT-token (from token transfer tile, token transfer summary or wherever else) - this requirement is not satisfied.
- There is no image of token loaded in the right box
https://...:4000/tokens/10306360948590189/instance/0x5caebd3b32e210e85ce3e9d51638b9c445481567- this is what is behind of QR-code in staging server. Obviously, this link doesn't open NFT-token instance page
pasqu4le
approved these changes
Sep 18, 2019
apps/block_scout_web/lib/block_scout_web/templates/tokens/instance/metadata/index.html.eex
Outdated
Show resolved
Hide resolved
vbaranov
requested changes
Sep 19, 2019
There was a problem hiding this comment.
@ayrat555 An error if to open ./metadata page for token instance, which has no metadata yet. Please handle it
2019-09-19T20:51:16.482 [error] #PID<0.2482.0> running BlockScoutWeb.Endpoint (connection #PID<0.2481.0>, stream id 1) terminated
Server: xxx
Request: GET /tokens/0x06012c8cf97bead5deae237070f9587f8e7a266d/instance/159293/metadata
** (exit) an exception was raised:
** (UndefinedFunctionError) function nil.metadata/0 is undefined
nil.metadata()
(block_scout_web) lib/block_scout_web/templates/tokens/instance/metadata/index.html.eex:19: BlockScoutWeb.Tokens.Instance.MetadataView."index.html"/1
(block_scout_web) lib/block_scout_web/templates/layout/app.html.eex:50: BlockScoutWeb.LayoutView."app.html"/1
(phoenix) lib/phoenix/view.ex:399: Phoenix.View.render_to_iodata/3
(phoenix) lib/phoenix/controller.ex:729: Phoenix.Controller.__put_render__/5
(block_scout_web) lib/block_scout_web/endpoint.ex:1: BlockScoutWeb.Endpoint.instrument/4
(phoenix) lib/phoenix/controller.ex:746: Phoenix.Controller.instrument_render_and_send/4
(block_scout_web) lib/block_scout_web/controllers/tokens/instance/metadata_controller.ex:1: BlockScoutWeb.Tokens.Instance.MetadataController.action/2
|
@vbaranov I fixed it |
|
@ayrat555 could you please fix merging conflicts? |
Fixed contract buttons color for NFT token instance on each theme.
vbaranov
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2541
ERC721 token instance pages can be accessed from the token inventory tab
Changelog