Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch address counters async #2663

Merged
merged 5 commits into from
Sep 9, 2019
Merged

fetch address counters async #2663

merged 5 commits into from
Sep 9, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Sep 3, 2019

In this PR (#2636)
we started fetching transactions and rewards in parallel using
elixir tasks.

This PR uses a similar approach to fetch validation and transaction
counters on the address page.

part of #2306

Motivation

Changelog

  • fetch address counters async

@ayrat555
fetch address counters async
87ab56b 
In this PR (#2636)
we started fetching transactions and rewards in parallel using
elixir tasks.

This PR uses similar approach to fetch validation and transaction
counters on address page.
@coveralls
Copy link

coveralls commented Sep 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build dcc3c162-75a5-41f1-a90d-c291f65c8e0e

  • 14 of 19 (73.68%) changed or added relevant lines in 11 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.009%) to 78.868%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/address_decompiled_contract_controller.ex 0 1 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_logs_controller.ex 0 1 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_validation_controller.ex 0 1 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_controller.ex 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/address_decompiled_contract_controller.ex 1 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_logs_controller.ex 1 0.0%
apps/block_scout_web/lib/block_scout_web/controllers/address_validation_controller.ex 2 0.0%
Totals Coverage Status
Change from base Build 1a8a390f-2176-43a5-b85d-5725115cd776: 0.009%
Covered Lines: 5154
Relevant Lines: 6535
💛 - Coveralls

pasqu4le
pasqu4le approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbaranov vbaranov merged commit 07290ee into master Sep 9, 2019
@vbaranov vbaranov deleted the ab-fetch-address-counters-async branch September 9, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayrat555 @coveralls @vbaranov @pasqu4le