Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Banner Fix. #2678

Merged
merged 2 commits into from
Sep 8, 2019
Merged

Conversation

YegorSan
Copy link
Contributor

@YegorSan YegorSan commented Sep 7, 2019

@vbaranov
Hello Victor. I've re-created this PR and closing #2673 with the same update, but with unresolved merge conflict. Finally, I've the resolved merge conflicts in my local repo, and will never push anything to master anymore:

Screenshot (1)
:

Motivation

Bug with dashboard banner must be resolved.

Changelog

Bug Fixes

Fixed jumping bug with dashboard banner on main Blockscout page.

Checklist for your PR

@vbaranov
Copy link
Member

vbaranov commented Sep 7, 2019

@YegorSan please add CHANGELOG entry

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 7, 2019

@vbaranov Hello. Added new changelog entry.

@vbaranov vbaranov merged commit 6efa964 into blockscout:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants