remove non-consensus data when inserting new consensus blocks #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrat555
changed the title
Pull Request Test Coverage Report for Build 328f20a3-9a4d-48b7-b00c-f97c33be5ca8
💛 - Coveralls |
pasqu4le
suggested changes
Sep 10, 2019
| } -> | ||
| nonconsensus_block_numbers = | ||
| lost_consensus_blocks | ||
| |> Kernel.++(lost_consensus_neighbours) |
There was a problem hiding this comment.
Just a nitpick, but I don't think credo will complain if you start the pipe with lost_consensus_blocks ++ lost_consensus_neighbours
pasqu4le
approved these changes
Sep 10, 2019
vbaranov
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR (#1657) we started invalidating a large number of blocks.
Imagine a situation when we just imported a non-consensus block. Logic in this PR sets
consensusto false for this block in the DB to makeCatchup.Fetcherre-fetch this block. But we already imported logs and token transfers for this non-consensus block. the second time we will import correct logs and transfers but invalid data is not deleted.fixes #2645
fixes #2627
Changelog