Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not stich json rpc config into module #2690

Merged
merged 3 commits into from
Nov 25, 2019

Conversation

ayrat555
Copy link
Contributor

Env vars are set after compilation so it causes @json_rpc_named_arguments to be nil

Changelog

  • do not stich json rpc config into module

@coveralls
Copy link

coveralls commented Sep 11, 2019

Pull Request Test Coverage Report for Build 976fb131-7256-46c3-99e3-76173145e4a0

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 75 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-1.06%) to 75.068%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http/httpoison.ex 1 0.0%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/parity/http_websocket.ex 1 0.0%
apps/indexer/lib/indexer/block/fetcher.ex 3 83.13%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/parity.ex 4 0.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex 12 52.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 53 11.25%
Totals Coverage Status
Change from base Build d61d07ad-6958-4a5c-8299-e45e7f15aabb: -1.06%
Covered Lines: 5263
Relevant Lines: 7011

💛 - Coveralls

@pasqu4le
Copy link
Contributor

CHANGELOG entry is missing BTW

@vbaranov vbaranov merged commit 59cc031 into master Nov 25, 2019
@vbaranov vbaranov deleted the ab-do-not-compile-json-rpc-config branch November 25, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants