Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude nonconsensus blocks from avg block time calculation by default #2701

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 16, 2019

Motivation

Excluding of nonconsensus blocks from avg block time calculation was introduced here #2266. But the default option was inclusion of such blocks whereas the most popular option is to calculate only consensus blocks.

Changelog

  • Change the default option of avg block time calculation - exclude nonconsensus blocks by default
  • Add UNCLES_IN_AVERAGE_BLOCK_TIME to docs. It was missing.

Checklist for your PR

@vbaranov vbaranov force-pushed the vb-exclude-uncles-from-avg-time-calc-by-default branch from 37815d8 to 5d9f7d0 Compare September 16, 2019 15:10
@vbaranov vbaranov requested review from pasqu4le and ayrat555 and removed request for pasqu4le September 16, 2019 15:10
@coveralls
Copy link

coveralls commented Sep 16, 2019

Pull Request Test Coverage Report for Build b080c9bc-f530-46f5-9d9f-773315725c28

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.419%

Totals Coverage Status
Change from base Build af1d77a6-23e4-4bb7-be63-b6ed26bc56b7: 0.0%
Covered Lines: 5189
Relevant Lines: 6617

💛 - Coveralls

@vbaranov vbaranov merged commit e254047 into master Sep 17, 2019
@vbaranov vbaranov deleted the vb-exclude-uncles-from-avg-time-calc-by-default branch September 17, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants