Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all addresses taking part in transactions in wallets' addresses counter #2718

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 20, 2019

Motivation

Wallets counter on the main page accounts only addresses with non-zero balance of native coins.
It should account addresses with zero coins balance too. After all, address can have zero coin balance but own some tokens.

Changelog

Wallets counter on the main page accounts all rows in the addresses table

Checklist for your PR

@coveralls
Copy link

coveralls commented Sep 20, 2019

Pull Request Test Coverage Report for Build c7f462a5-b9e6-4e9b-969a-d9b7b6344df8

  • 14 of 19 (73.68%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 78.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/counters/addresses_counter.ex 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain_spec/genesis_data.ex 5 9.09%
Totals Coverage Status
Change from base Build 6c20372f-9bce-4b44-966d-2ac336a1cbf8: -0.002%
Covered Lines: 5264
Relevant Lines: 6699

💛 - Coveralls

@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed wip labels Sep 20, 2019
Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

apps/explorer/lib/explorer/counters/addresses_counter.ex Outdated Show resolved Hide resolved
@vbaranov vbaranov merged commit 1f90f7e into master Sep 23, 2019
@vbaranov vbaranov deleted the vb-addresses-counter branch September 23, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants