Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched hardcoded subnetwork value to elixir expression for mobile menu. #2737

Merged
merged 3 commits into from
Sep 26, 2019

Conversation

YegorSan
Copy link
Contributor

@YegorSan YegorSan commented Sep 26, 2019

Motivation

Sub-network value for mobile view was hardcoded. I've added Elixir expression in order to get the required value according to selected sub-network.

Changelog

Bug Fixes

Fixed rendering of sub network title in mobile view.

Unfortunately I can not provide screenshot, as locally I can run app only on Sokol Testnet, and if I switch network, it redirects to production app. But I've tested everything, firstly I removed hardcoded value and checked - nothing appeared in menu, then I've added elixir expression, and Sokol Testnet value appeared as it expected.

Checklist for your PR

@vbaranov vbaranov merged commit 6d461f5 into blockscout:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants