optimize txlist json rpc #2781
Merged
optimize txlist json rpc #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the query was sorted by transactions.block_number field which doesn't have db index (#2698). Now we will start sorting by blocks.number since transactions are joined with blocks anyway.
Pull Request Test Coverage Report for Build 1e5c892b-4878-48c8-a942-4adccd423f53
💛 - Coveralls |
vbaranov
approved these changes
Oct 16, 2019
pasqu4le
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Just one question. Also I may be wrong but I think I tried sorting by block number myself at one point and postgres EXPLAIN predicted a slightly worst performance.
Do you know if that was because of the ascending order? It is very possible that I don't remember correctly BTW
| @@ -1189,7 +1189,7 @@ defmodule BlockScoutWeb.Etherscan do | |||
| key: "sort", | |||
| type: "string", | |||
| description: | |||
| "A string representing the order by block number direction. Defaults to ascending order. Available values: asc, desc" | |||
| "A string representing the order by block number direction. Defaults to descending order. Available values: asc, desc" | |||
There was a problem hiding this comment.
Does the descending order make a difference in performance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1319
the query was sorted by transactions.block_number field
which doesn't have db
index (#2698).
Now we will start sorting by blocks.number since transactions are
joined with blocks anyway.
Changelog