add ipc client #2791
Merged
add ipc client #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3892e464-8dda-4f07-a0c1-f549e2c739e5
💛 - Coveralls |
vbaranov
approved these changes
Oct 23, 2019
vbaranov
reviewed
Oct 23, 2019
pasqu4le
approved these changes
Oct 29, 2019
|
|
||
| response = :gen_tcp.connect({:local, state[:path]}, 0, opts) | ||
|
|
||
| case response do |
There was a problem hiding this comment.
I think this could be handled using a with
| else | ||
| {:error, %Jason.DecodeError{data: ""}} -> {:error, :empty_response} | ||
| {:error, error} -> {:error, {:invalid_json, error}} | ||
| {:error, error} -> {:error, error} |
There was a problem hiding this comment.
I think this last clause never matches, because the one just above is the same and takes precedence.
Another atom in the tuple should allow you to separate them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2790
docs update blockscout/docs#2
Two env variables should be set
ETHEREUM_JSONRPC_JSON_RPC_TRANSPORT=ipcandIPC_PATH=path_to_ipcChangelog