Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block validator custom tooltip #2803

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 25, 2019

#2622

Motivation

Before:

Screenshot 2019-10-25 at 14 56 57

After:

Screenshot 2019-10-25 at 14 51 12
Screenshot 2019-10-25 at 14 50 55
Screenshot 2019-10-25 at 14 50 33

Changelog

Bug Fixes

  • update .tooltipCustom class styles
  • remove unused styles
  • add use_custom_tooltip parameter for BlockScoutWeb.AddressView
  • hide basic tooltip if use_custom_tooltip is true

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-block-validator-custom-tooltip branch from 70d1001 to 114e1e2 Compare October 25, 2019 11:55
@vbaranov vbaranov changed the title Block validator custom tooltip Fix block validator custom tooltip Oct 25, 2019
@vbaranov vbaranov force-pushed the vb-block-validator-custom-tooltip branch from 114e1e2 to 408669b Compare October 25, 2019 12:01
@coveralls
Copy link

coveralls commented Oct 25, 2019

Pull Request Test Coverage Report for Build 0b426a04-db41-418b-a625-16d5e3a173b7

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 76.785%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token_instance.ex 1 14.29%
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 5a34f4b0-f9e1-41c3-a00b-ad47a04e51c0: -0.04%
Covered Lines: 5302
Relevant Lines: 6905

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-block-validator-custom-tooltip branch from 408669b to 7d56004 Compare October 25, 2019 13:02
@vbaranov vbaranov self-assigned this Oct 25, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Oct 25, 2019
@vbaranov vbaranov marked this pull request as ready for review October 25, 2019 13:30
@vbaranov vbaranov merged commit 982b65f into master Oct 29, 2019
@vbaranov vbaranov deleted the vb-block-validator-custom-tooltip branch October 29, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants