Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

422 page #2807

Merged
merged 6 commits into from
Oct 29, 2019
Merged

422 page #2807

merged 6 commits into from
Oct 29, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 28, 2019

Closes #2415

Finalization of #2766

Motivation

Before:
Screenshot 2019-10-28 at 14 13 36

After:
Screenshot 2019-10-28 at 13 57 45

Changelog

Enhancements

  • new styles/template/view for 422 error
  • modified controller to use a new view

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Oct 28, 2019
@coveralls
Copy link

coveralls commented Oct 28, 2019

Pull Request Test Coverage Report for Build 58286e4e-051a-4709-b0e1-41a8d2fab4a5

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.632%

Totals Coverage Status
Change from base Build f93b29da-1a29-4564-9706-b8f8e15f9631: 0.0%
Covered Lines: 5306
Relevant Lines: 6924

💛 - Coveralls

@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Oct 28, 2019
@vbaranov vbaranov marked this pull request as ready for review October 28, 2019 11:21
@vbaranov vbaranov merged commit ca5c0ea into master Oct 29, 2019
@vbaranov vbaranov deleted the 422-page branch October 29, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a design for 422 page
5 participants