allow hiding marketcap percentage #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 600fcbec-7c3c-43d2-a770-5db8a2308340
💛 - Coveralls |
ayrat555
added a commit
to ayrat555/docs
that referenced
this pull request
Oct 29, 2019
should be merged after blockscout/blockscout#2818
pasqu4le
approved these changes
Oct 29, 2019
apps/block_scout_web/lib/block_scout_web/templates/address/index.html.eex
Outdated
Show resolved
Hide resolved
vbaranov
requested changes
Nov 1, 2019
Comment on lines
250
to
257
| #, elixir-format | ||
| #: lib/block_scout_web/templates/address/_tabs.html.eex:32 | ||
| #: lib/block_scout_web/templates/address/overview.html.eex:97 | ||
| #: lib/block_scout_web/templates/address_validation/index.html.eex:13 | ||
| #: lib/block_scout_web/views/address_view.ex:313 | ||
| msgid "Blocks Validated" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
@ayrat555 what is the rationale to change the placement of these strings in the internalization file? Please let's leave them as is. Otherwise, there will be merging conflicts.
There was a problem hiding this comment.
@vbaranov to fix merging conflicts. Let me try to change only line numbers
|
@vbaranov I addressed your comment |
vbaranov
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
resolves #2567
Changelog