Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update int txs constraints repairing script #2835

Merged
merged 4 commits into from
Nov 27, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 4, 2019

Motivation

Update internal transactions constraints fixing script by accounting pending_block_operations table

Note: should be merged after #2820 since it utilizes fetch_internal_transactions column in pending_block_operations table, which is a part of migration in #2820

Changelog

20181108205650_large_additional_internal_transaction_constraints.sql script update

Checklist for your Pull Request (PR)

pasqu4le and others added 3 commits October 29, 2019 18:13
Problem: a lot of problems are created by tracking the importing progress on multiple tables.
Querying and updating involves as such heavy operations and this is also the cause for inconsistencies.

Solution: use a new table to track the progress of block's data indexing.
By using a specific table, whose rows are deleted when there are no more pending operations on the relative block, we make joins quick and keep them to a minimum.
This is also meant to simplify all inserts and updates and only perform deletes when strictly necessary.
@vbaranov vbaranov force-pushed the vb-update-int-txs-constraints-script branch from 5d111df to 3699b5e Compare November 4, 2019 12:58
@coveralls
Copy link

coveralls commented Nov 4, 2019

Pull Request Test Coverage Report for Build 2e762c05-a952-4069-90db-b64a926a5377

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 58 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.8%) to 75.595%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/transform/addresses.ex 1 75.0%
apps/indexer/lib/indexer/block/fetcher.ex 3 83.13%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex 7 64.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 47 18.75%
Totals Coverage Status
Change from base Build ba9042ac-5938-4ebb-9a2d-b2e72c31dd1f: -0.8%
Covered Lines: 5238
Relevant Lines: 6929

💛 - Coveralls

@vbaranov vbaranov marked this pull request as ready for review November 4, 2019 19:06
@vbaranov vbaranov self-assigned this Nov 4, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. indexing labels Nov 4, 2019
@vbaranov vbaranov merged commit 7d92e6d into pp-pending-block-ops Nov 27, 2019
@vbaranov vbaranov deleted the vb-update-int-txs-constraints-script branch November 27, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
indexing ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants