Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokenID for tokentx API action explicitly #2918

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Dec 10, 2019

#2912

Motivation

tokenID is missing in tokentx API endpoint

Changelog

Add tokenID in output for tokentx endpoint explicitly in case of ERC-721 token instead to write the value to value key

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Dec 10, 2019
@coveralls
Copy link

coveralls commented Dec 10, 2019

Pull Request Test Coverage Report for Build ef9ee19b-ccb7-41ef-9a5f-1a360995a384

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 75.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/api/rpc/address_view.ex 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
apps/block_scout_web/lib/block_scout_web/views/address_transaction_view.ex 1 75.0%
Totals Coverage Status
Change from base Build 64bd01df-77cb-4ec3-9f0d-cc2c8a6359d0: 0.004%
Covered Lines: 5297
Relevant Lines: 7053

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-token-id-for-tokentx-api-action branch from 59d5ed0 to 92e4963 Compare December 10, 2019 16:52
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Dec 10, 2019
@vbaranov vbaranov changed the title Add tokenID for tokentx API action Add tokenID for tokentx API action explicitly Dec 10, 2019
@vbaranov vbaranov added the api API endpoints label Dec 11, 2019
@vbaranov vbaranov added this to the 3.0.0 milestone Dec 18, 2019
@vbaranov vbaranov merged commit b73d2ec into master Dec 20, 2019
@vbaranov vbaranov deleted the vb-token-id-for-tokentx-api-action branch December 20, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API endpoints ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants