Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate websocket connection #2932

Merged
merged 2 commits into from
Dec 24, 2019
Merged

Fix duplicate websocket connection #2932

merged 2 commits into from
Dec 24, 2019

Conversation

maxaleks
Copy link
Collaborator

@maxaleks maxaleks commented Dec 24, 2019 •
edited
Loading

Problem: the same websocket connection is initialized in 2 separate scripts, because both scripts use lib/currency.js

Solution: moved websocket connection from lib/currency.js to pages/chain.js

@coveralls
Copy link

coveralls commented Dec 24, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build bd1f8ae0-ab19-46cf-97ba-f4a066d7761c

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.127%
Totals Coverage Status
Change from base Build d638b414-2159-4d7e-b040-9fb0365e535a: 0.0%
Covered Lines: 5304
Relevant Lines: 7060
💛 - Coveralls

@vbaranov vbaranov merged commit 1409900 into master Dec 24, 2019
@vbaranov vbaranov deleted the fix-websockets-connection branch December 24, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxaleks @coveralls @vbaranov