Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of 0.6.x version of solc compiler #2956

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jan 16, 2020

Fixes #2957

Motivation

  • Add support of 0.6.x version of compiler
  • Add istanbul to supported evm list in verification
  • increase solc npm package version up to 0.6.1

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-extend-default-list-of-evms branch from cd19431 to 2603378 Compare January 16, 2020 16:53
@vbaranov vbaranov self-assigned this Jan 16, 2020
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jan 16, 2020
@vbaranov vbaranov changed the title Add istanbul to supported evm list in verification Add istanbul to supported evm list in contracts verification Jan 16, 2020
@coveralls
Copy link

coveralls commented Jan 16, 2020

Pull Request Test Coverage Report for Build 96b6453f-017d-4889-90c5-df28c2c703ea

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 75.252%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/smart_contract/verifier.ex 0 1 0.0%
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build c86d1745-4ddc-4f80-88f5-bd26fdb594a3: 0.004%
Covered Lines: 5376
Relevant Lines: 7144

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-extend-default-list-of-evms branch from 2603378 to 222f565 Compare January 16, 2020 19:23
@vbaranov vbaranov added wip and removed ready for review This PR is ready for reviews. labels Jan 16, 2020
@vbaranov vbaranov changed the title Add istanbul to supported evm list in contracts verification Various contract verfication fixes Jan 16, 2020
@vbaranov vbaranov force-pushed the vb-extend-default-list-of-evms branch 2 times, most recently from 07d1b5a to dd3ff86 Compare January 20, 2020 15:17
@vbaranov vbaranov changed the title Various contract verfication fixes Add support of 0.6.x version of compiler Jan 20, 2020
@vbaranov vbaranov force-pushed the vb-extend-default-list-of-evms branch from dd3ff86 to 28c98ab Compare January 20, 2020 15:23
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed wip labels Jan 20, 2020
@vbaranov vbaranov changed the title Add support of 0.6.x version of compiler Add support of 0.6.x version of solc compiler Jan 20, 2020
@vbaranov vbaranov force-pushed the vb-extend-default-list-of-evms branch from 28c98ab to 0b24d78 Compare January 20, 2020 15:37
@vbaranov vbaranov merged commit feba38a into master Jan 20, 2020
@vbaranov vbaranov deleted the vb-extend-default-list-of-evms branch January 20, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of solc compiler 0.6.x
2 participants