Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ex_abi 0.3.0 #3053

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Migrate to ex_abi 0.3.0 #3053

merged 4 commits into from
Mar 19, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 13, 2020

Fixes #1258
Fixes #3048
Fixes #3049

Motivation

Blockscout doesn't support decoding of ABI-encoded parameters of non-fixed length.

Related PR to update ex_abi library poanetwork/ex_abi#24

Changelog

  • import ex_abi 0.3.0
  • extend decode_result function cases
  • fix tests

Checklist for your Pull Request (PR)

@vbaranov vbaranov added the wip label Mar 13, 2020
@coveralls
Copy link

coveralls commented Mar 13, 2020

Pull Request Test Coverage Report for Build d94b1255-a3b9-4206-9825-c9a6ba2f6287

  • 4 of 7 (57.14%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 75.075%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/address_contract_view.ex 0 1 0.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/encoder.ex 1 2 50.0%
apps/explorer/lib/explorer/smart_contract/reader.ex 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 55bc48ba-113b-4343-9240-cc046db58f23: -0.04%
Covered Lines: 5512
Relevant Lines: 7342

💛 - Coveralls

@vbaranov vbaranov force-pushed the ex_abi_update branch 3 times, most recently from b40d5f9 to d33f8a7 Compare March 17, 2020 18:26
@vbaranov vbaranov changed the title ex_abi 0.2.2 ex_abi 0.3.0 Mar 17, 2020
@vbaranov vbaranov changed the title ex_abi 0.3.0 Migrate to ex_abi 0.3.0 Mar 17, 2020
@vbaranov vbaranov force-pushed the ex_abi_update branch 4 times, most recently from 5d432c2 to d90bca8 Compare March 18, 2020 18:17
@vbaranov vbaranov merged commit 9a648e0 into master Mar 19, 2020
@vbaranov vbaranov deleted the ex_abi_update branch March 19, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants