Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude balance percentage calculation for burn address on accounts page #3122

Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 22, 2020

Fixes #3103

Motivation

#3103 (comment)

Changelog

Doesn't show balance percentage to market cap for burn address.

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this May 22, 2020
@vbaranov vbaranov force-pushed the vb-exclude-balance-percentage-calc-from-burn-address branch 2 times, most recently from 0eab64b to bde6b2a Compare May 22, 2020 13:07
@coveralls
Copy link

coveralls commented May 22, 2020

Pull Request Test Coverage Report for Build 7f75aa3b-d0de-4a91-887c-5f99963dd11f

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 75.086%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
apps/explorer/lib/explorer/chain_spec/genesis_data.ex 5 9.09%
Totals Coverage Status
Change from base Build acb221d3-f43d-4c53-bb95-61ce16abad7c: 0.0%
Covered Lines: 5705
Relevant Lines: 7598

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-exclude-balance-percentage-calc-from-burn-address branch from bde6b2a to 26a651c Compare May 22, 2020 13:16
@vbaranov vbaranov merged commit 98df4e5 into master May 22, 2020
@vbaranov vbaranov deleted the vb-exclude-balance-percentage-calc-from-burn-address branch May 22, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omit 0x0 address from this list: https://blockscout.com/poa/xdai/accounts
2 participants