Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display upper border for tx speed if the value cannot be calculated #3124

Merged
merged 7 commits into from
May 25, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 25, 2020

Fixes #3072

Changelog

Screenshot 2020-05-22 at 15 27 59

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Vb upper border tx speed display Display upper border for tx speed if the value cannot be calculated May 25, 2020
@coveralls
Copy link

coveralls commented May 25, 2020

Pull Request Test Coverage Report for Build 163303d7-8ed9-48ca-8d52-de2397f92cb5

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 75.072%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/transaction_view.ex 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
apps/block_scout_web/lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build 547513a4-ec04-4fc6-9d77-bc844312e015: -0.07%
Covered Lines: 5707
Relevant Lines: 7602

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-upper-border-tx-speed-display branch from 9f45f9f to c329da1 Compare May 25, 2020 08:36
@vbaranov vbaranov force-pushed the vb-upper-border-tx-speed-display branch from c329da1 to 2a2a510 Compare May 25, 2020 08:45
@vbaranov vbaranov force-pushed the vb-upper-border-tx-speed-display branch from 5373bac to a68ec64 Compare May 25, 2020 10:58
@vbaranov vbaranov merged commit 95c5856 into master May 25, 2020
@vbaranov vbaranov deleted the vb-upper-border-tx-speed-display branch May 25, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Parameter on the Details of Transaction History: TRANSACTION SPEED
2 participants