Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account FIRST_BLOCK for block rewards fetching #3130

Merged
merged 1 commit into from
May 27, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 27, 2020

Motivation

blockscout     | 2020-05-27T07:53:08.769 application=indexer fetcher=block_reward count=10 error_count=10 [error] failed to fetch: @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error
blockscout     | @�: (-32603) Internal error

Changelog

Validate blocks which send to trace_block JSON RPC method. The numbers should be greater than FIRST_BLOCK param.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-rewards-first-block-limit branch from 28c222e to 93a2fd4 Compare May 27, 2020 07:56
@vbaranov vbaranov self-assigned this May 27, 2020
@coveralls
Copy link

coveralls commented May 27, 2020

Pull Request Test Coverage Report for Build 017d1d20-defc-4659-b7ce-62566cfe689e

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 75.089%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 3 85.19%
Totals Coverage Status
Change from base Build b26d515d-8cb1-47ca-a4c6-3a8086bd0b4a: -0.02%
Covered Lines: 5721
Relevant Lines: 7619

💛 - Coveralls

@vbaranov vbaranov merged commit e48e438 into master May 27, 2020
@vbaranov vbaranov deleted the vb-rewards-first-block-limit branch May 27, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants