Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSK Papyrus Release v2.0.1 hardfork: cumulativeDifficulty #3137

Merged
merged 1 commit into from
May 28, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 28, 2020

Motivation

https://github.com/rsksmart/rskj/releases/tag/PAPYRUS-2.0.1
happened at block 2,392,700 and causes an error in Blockscout:

2020-05-28T12:36:58.685 application=indexer fetcher=block_catchup first_block_number=2393023 last_block_number=2393014 [error] ** (FunctionClauseError) no function clause matching in EthereumJSONRPC.Block.entry_to_elixir/1
    (ethereum_jsonrpc 0.1.0) EthereumJSONRPC.Block.entry_to_elixir({"cumulativeDifficulty", "0x2c912722075cffd936"})
    (elixir 1.10.2) lib/enum.ex:1320: anonymous fn/4 in Enum.into/3
    (stdlib 3.9.2) maps.erl:232: :maps.fold_1/3
    (elixir 1.10.2) lib/enum.ex:2127: Enum.into/4
    (elixir 1.10.2) lib/enum.ex:1396: Enum."-map/2-lists^map/1-0-"/2
    (ethereum_jsonrpc 0.1.0) lib/ethereum_jsonrpc/blocks.ex:44: EthereumJSONRPC.Blocks.from_responses/2
    (ethereum_jsonrpc 0.1.0) lib/ethereum_jsonrpc.ex:464: EthereumJSONRPC.fetch_blocks_by_params/3
    (indexer 0.1.0) lib/indexer/block/fetcher.ex:130: Indexer.Block.Fetcher.fetch_and_import_range/2


Retrying.

Changelog

Add cumulativeDifficulty to the list of expected parameters from block details JSON RPC response

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this May 28, 2020
@vbaranov vbaranov merged commit 20f134d into master May 28, 2020
@vbaranov vbaranov deleted the vb-rsk-hardfork branch May 28, 2020 14:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1f506c3a-d9b3-4151-8bc9-94a281d902e0

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.056%

Totals Coverage Status
Change from base Build a1d0822c-1e55-4245-ad7a-64a95e2a5a88: 0%
Covered Lines: 5729
Relevant Lines: 7633

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants