Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read methods of implementation on proxy contract #3157

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jun 19, 2020

#2839

Motivation

Missing useful read proxy contract feature.

Changelog

Screenshot 2020-06-19 at 15 27 25

Note: in order to enable this feature both proxy and implementation contracts should be verified inn Blockscout and proxy contract should have "implementation" getter with the address of current implementation.

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jun 19, 2020
@coveralls
Copy link

coveralls commented Jun 19, 2020

Pull Request Test Coverage Report for Build f3eaf00b-4cab-4670-b4a6-b974b34a9a95

  • 40 of 43 (93.02%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 74.347%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/address_view.ex 1 2 50.0%
apps/explorer/lib/explorer/chain.ex 16 17 94.12%
apps/explorer/lib/explorer/smart_contract/reader.ex 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain.ex 2 75.45%
apps/block_scout_web/lib/block_scout_web/controllers/smart_contract_controller.ex 3 85.71%
Totals Coverage Status
Change from base Build 02031898-6fc5-45f2-a08a-2e099dc79126: 0.009%
Covered Lines: 5892
Relevant Lines: 7925

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-read-proxy branch 3 times, most recently from e08c5ba to 4639e79 Compare June 19, 2020 13:40
@vbaranov vbaranov force-pushed the vb-read-proxy branch 2 times, most recently from b5432a2 to 23649af Compare June 19, 2020 16:23
@vbaranov vbaranov merged commit f77ff79 into master Jun 21, 2020
@vbaranov vbaranov deleted the vb-read-proxy branch June 21, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants