Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display implementation address at read/write proxy tabs #3173

Merged
merged 1 commit into from Jun 30, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jun 30, 2020

Resolves #3162

Motivation

Implementation address is not displayed at read/write proxy tabs

Changelog

Screenshot 2020-06-30 at 14 44 55

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jun 30, 2020
@coveralls
Copy link

coveralls commented Jun 30, 2020

Pull Request Test Coverage Report for Build dac3b6d1-f434-4fc5-99e7-e4dd25d81ec5

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 74.374%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 3 85.19%
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 69.88%
Totals Coverage Status
Change from base Build be954bf9-bf72-46e6-a1fa-db3b81cc8979: -0.1%
Covered Lines: 5967
Relevant Lines: 8023

💛 - Coveralls

@vbaranov vbaranov merged commit 818f0d5 into master Jun 30, 2020
@vbaranov vbaranov deleted the vb-implementation-address branch June 30, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add implementation address on Read/Write proxy tabs.
2 participants