Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract interaction: array input type parsing fix #3259

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 27, 2020

Resolves #3255

Motivation

Array input in contract interactions doesn't encode correctly

Changelog

Parse input types in order to check if array type presents and format input in that case

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Contract interaction: array input type Contract interaction: array input type parsing fix Aug 28, 2020
@github-actions
Copy link

Pull Request Test Coverage Report for Build bf93acf817b2ebeb2784a93a2295e1df0259283c-PR-3259

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.4%) to 55.155%

Totals Coverage Status
Change from base Build ea694bfffdd0948f2e06b72265039f00d7806fad: -15.4%
Covered Lines: 444
Relevant Lines: 805

💛 - Coveralls

@vbaranov vbaranov marked this pull request as ready for review August 28, 2020 08:54
@vbaranov vbaranov merged commit 878ab21 into master Aug 28, 2020
@vbaranov vbaranov deleted the vb-contract-int-array-input branch August 28, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use contract's getter with array argument
1 participant