Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite market cap for xDai: TokenBridge + OmniBridge #3293

Merged
merged 5 commits into from
Sep 21, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 15, 2020

Motivation

xDai market cap is currently comprised from xDai minted with TokenBridge and assets bridged from Mainnet by means of OmniBridge. We should account both in market cap on the main page. Currently, only TokenBridge is accounted.

Changelog

Screenshot 2020-09-16 at 17 25 19

BRIDGE_MARKET_CAP_UPDATE_INTERVAL - environment variable introduced.

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Sep 15, 2020

Pull Request Test Coverage Report for Build e728afc227aeadcff49b7f09f3299f173f8db175-PR-3293

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+6.5%) to 75.578%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
lib/block_scout_web/controllers/chain_controller.ex 5 86.49%
lib/block_scout_web/views/chain_view.ex 12 14.29%
Totals Coverage Status
Change from base Build a3282e8af436a7249f8af856d29aeb7ee0fa638c: 6.5%
Covered Lines: 1928
Relevant Lines: 2551

💛 - Coveralls

@vbaranov vbaranov changed the title Composite market cap for xDai: TokenBridge + OminBridge Composite market cap for xDai: TokenBridge + OmniBridge Sep 15, 2020
@vbaranov vbaranov force-pushed the vb-xdai-omni-market-cap branch 8 times, most recently from 2b575a2 to 9da84c8 Compare September 16, 2020 14:08
@vbaranov vbaranov marked this pull request as ready for review September 16, 2020 14:28
@vbaranov vbaranov merged commit d2694d6 into master Sep 21, 2020
@vbaranov vbaranov deleted the vb-xdai-omni-market-cap branch September 21, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants