Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Solc binary downloader path to official primary supported path #3341

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 12, 2020

Motivation

https://ethereum.github.io/solc-bin/bin/soljson-#{version}.js URL to download Solc binary doesn't work for the version of compiler >= 0.7.2

Changelog

Change Solc compiler download URL to https://solc-bin.ethereum.org/bin/soljson-#{version}.js. It is officially supported primary way https://gitter.im/ethereum/solidity-dev?at=5f8418f402e81701b017f522.

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Oct 12, 2020

Pull Request Test Coverage Report for Build d81e6630fdf58b855b36bd884ab176df1b722df3-PR-3341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+3.6%) to 74.727%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build 9b7438f3c1a726913610b94d37b7ac1acc8245c3: 3.6%
Covered Lines: 1987
Relevant Lines: 2659

💛 - Coveralls

@vbaranov vbaranov merged commit aa40b42 into master Oct 12, 2020
@vbaranov vbaranov deleted the vb-fix-solc-downloader-path branch October 12, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants