Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract nested inputs #3376

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Fix contract nested inputs #3376

merged 1 commit into from
Oct 21, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 21, 2020

Motivation

Transformation of nested inputs like array from an array into form' view in contract method cause application Internal server error

image

Changelog

Handling of nested input types

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-fix-contract-nested-inputs branch from ca84521 to 9ea50a3 Compare October 21, 2020 09:10
@coveralls
Copy link

coveralls commented Oct 21, 2020

Pull Request Test Coverage Report for Build 0c58cdbd9bd5b73c4d3f6eb46d452a636a95aef2-PR-3376

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.05%) to 67.393%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/channels/address_channel.ex 2 36.96%
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build 51ed8743b37b96b1e7840b14b6f07632695178b0: 1.05%
Covered Lines: 2042
Relevant Lines: 3030

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-fix-contract-nested-inputs branch from 9ea50a3 to 0c58cdb Compare October 21, 2020 11:24
@vbaranov vbaranov merged commit bf53cf5 into master Oct 21, 2020
@vbaranov vbaranov deleted the vb-fix-contract-nested-inputs branch October 21, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants