Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize docker vars list #3394

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Actualize docker vars list #3394

merged 1 commit into from
Oct 26, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 26, 2020

Motivation

Add to Docker setup recently added ENV vars

Changelog

Enhancements

Things you added that don't break anything. Regression tests for Bug Fixes count as Enhancements.

Bug Fixes

Things you changed that fix bugs. If a fixes a bug, but in so doing adds a new requirement, removes code, or requires a database reset and reindex, the breaking part of the change should be added to Incompatible Changes below also.

Incompatible Changes

Things you broke while doing Enhancements and Bug Fixes. Breaking changes include (1) adding new requirements and (2) removing code. Renaming counts as (2) because a rename is a removal followed by an add.

Upgrading

If you have any Incompatible Changes in the above Changelog, outline how users of prior versions can upgrade once this PR lands or when reviewers are testing locally. A common upgrading step is "Database reset and re-index required".

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Oct 26, 2020

Pull Request Test Coverage Report for Build 9122d6802349ba44ff0180c62d1cdfb07d4a377b-PR-3394

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.001%) to 67.611%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
lib/block_scout_web/channels/address_channel.ex 2 36.96%
Totals Coverage Status
Change from base Build e7800712e716ef53c3291ec6fe4a12c6739055e5: -1.001%
Covered Lines: 2052
Relevant Lines: 3035

💛 - Coveralls

@vbaranov vbaranov merged commit 973faf0 into master Oct 26, 2020
@vbaranov vbaranov deleted the vb-docker-vars-update branch October 26, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants