Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N/A instead of 0 for market cap if it is not fetched #3405

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 28, 2020

Motivation

If TokenBridge MarketCap can not be calculated for some reason Blockscout displays 0, what can confuse users. We should display "N/A" instead.

Changelog

Screenshot 2020-10-28 at 13 12 20

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Oct 28, 2020

Pull Request Test Coverage Report for Build 4786beb1bf71c52bb1a1b914ed8261cce8a99b99-PR-3405

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+3.0%) to 67.512%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build fc3c60ce3987ad1a5e51e696c94ffe376131c5c1: 3.0%
Covered Lines: 2049
Relevant Lines: 3035

💛 - Coveralls

@vbaranov vbaranov merged commit b21659f into master Oct 28, 2020
@vbaranov vbaranov deleted the vb-market-cap-na-instead-0 branch October 28, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants