Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace window.web3 with window.ethereum #3450

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 12, 2020

Motivation

MetaMask will discontinue injecting window.web3 object to the page https://docs.metamask.io/guide/provider-migration.html#replacing-window-web3. We should handle this change.

Changelog

Replace injected window.web3 object with window.ethereum

Chore:

  • refactor write contract functionality

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Nov 12, 2020

Pull Request Test Coverage Report for Build 59d2f71f0c9c85de9af5563b1d59661d0b21f3b6-PR-3450

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 67.266%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 4e520f7ec3fef1b27f6b123fd18c3723c82ba9e6: 0.3%
Covered Lines: 2057
Relevant Lines: 3058

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-eliminate-window-web3 branch 4 times, most recently from 3fb9ac4 to 407b9d0 Compare November 15, 2020 10:17
@vbaranov vbaranov merged commit e6fb89b into master Nov 16, 2020
@vbaranov vbaranov deleted the vb-eliminate-window-web3 branch November 16, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants