Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts interaction: fix tuple output display, fix array input #3494

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Nov 30, 2020

#3486
#3488

Motivation

  • Error at "Read contract" page of the contract with non-empty tuple output
  • Warning at "Write contract" page for writing function with "address[]" input

Chore:

  • Remove highlightjs-solidity package since it doesn't comply with the latest webpack@5. An error returns:
    TypeError: react__WEBPACK_IMPORTED_MODULE_2___default(…) is not a function

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Nov 30, 2020

Pull Request Test Coverage Report for Build 84d7ff968eb131c72afc85623c6b345ec3645f76-PR-3494

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.2%) to 66.871%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/channels/address_channel.ex 2 36.96%
lib/block_scout_web/views/smart_contract_view.ex 9 65.38%
Totals Coverage Status
Change from base Build 91b3be3e9f10d52608e8b377405bcc2043525dff: -1.2%
Covered Lines: 2069
Relevant Lines: 3094

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants