Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address token balance on demand fetcher #3525

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Dec 17, 2020

Motivation

Address page in some cases shows stale tokens balance.

Changelog

As a patch (not a solid solution of the issue) on-demand token balance fetcher is introduced. With default stale balance window 24hrs.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-token-balance-on-demand-fetcher branch from 1c35b72 to 9530e36 Compare December 17, 2020 13:35
@coveralls
Copy link

coveralls commented Dec 17, 2020

Pull Request Test Coverage Report for Build 9530e367232b19b82e7d89861a02ee7e6076724a-PR-3525

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.6%) to 66.677%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/checksum_address.ex 6 55.56%
lib/block_scout_web/controllers/address_token_balance_controller.ex 6 52.63%
lib/block_scout_web/notifier.ex 9 84.09%
Totals Coverage Status
Change from base Build c778962836e19ba99b01371d086b5af40db53d52: 0.6%
Covered Lines: 2069
Relevant Lines: 3103

💛 - Coveralls

@vbaranov vbaranov merged commit 0c39013 into master Dec 17, 2020
@vbaranov vbaranov deleted the vb-token-balance-on-demand-fetcher branch December 17, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants