Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force to show filter at the page where filtered items list is empty #3567

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jan 14, 2021

#3559

Motivation

Force to show a filter at filtered items list page if the items list is empty. It improves UX: users don't need anymore to refresh the page in order to see all items.

Changelog

Screenshot 2021-01-14 at 13 25 54

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-show-filter-if-no-items-in-filter branch from d5405af to 5d67a9e Compare January 14, 2021 10:28
@coveralls
Copy link

coveralls commented Jan 14, 2021

Pull Request Test Coverage Report for Build 25e46776f67c2743829f8c4d824d7e03ec00d708-PR-3567

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 66.806%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build 7828960c6cb67bfb1ed9058ea5b0f94e10821b6b: 1.3%
Covered Lines: 2079
Relevant Lines: 3112

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-show-filter-if-no-items-in-filter branch from 5d67a9e to 25e4677 Compare January 14, 2021 10:39
@vbaranov vbaranov merged commit 74011c5 into master Jan 14, 2021
@vbaranov vbaranov deleted the vb-show-filter-if-no-items-in-filter branch January 14, 2021 11:55
@vbaranov vbaranov mentioned this pull request Jan 14, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants