Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent update validator metadata with empty name from contract #3600

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 1, 2021

Motivation

If validator's name is not from the metadata contract (hardcoded in DB), it wipes with empty name on the next scheduled update of metadata

Changelog

Do not update metadata if name in contract's is empty

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Prevent update validator with empty name from contract Prevent update validator metadata with empty name from contract Feb 1, 2021
@vbaranov vbaranov force-pushed the vb-prevent-update-of-validator-with-empty-name branch from 58a6dbf to 7e5a2a4 Compare February 1, 2021 19:27
@coveralls
Copy link

coveralls commented Feb 1, 2021

Pull Request Test Coverage Report for Build 7e5a2a40c9577b6a4bcd889f48090eb268895e03-PR-3600

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.6%) to 65.618%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
Totals Coverage Status
Change from base Build f9b34d2546520b5f11b829c29d15a78dfe89c1f3: 1.6%
Covered Lines: 2086
Relevant Lines: 3179

💛 - Coveralls

@vbaranov vbaranov merged commit c6fd17b into master Feb 2, 2021
@vbaranov vbaranov deleted the vb-prevent-update-of-validator-with-empty-name branch February 2, 2021 06:58
@vbaranov vbaranov mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants