Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract reader: fix int type output #3622

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 12, 2021

Motivation

Resolve Internal server error caused by Int(x) type "0" value in the output of the contract method

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Feb 12, 2021

Pull Request Test Coverage Report for Build 6d3d0a5531cb1276072272c06719a6f1661ef62f-PR-3622

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.7%) to 64.8%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
lib/block_scout_web/checksum_address.ex 6 55.56%
lib/block_scout_web/views/smart_contract_view.ex 29 37.76%
Totals Coverage Status
Change from base Build c6d43e2d8e456e24dcf66078c0c9fc5699f25509: -1.7%
Covered Lines: 2095
Relevant Lines: 3233

💛 - Coveralls

@vbaranov vbaranov merged commit 392317e into master Feb 12, 2021
@vbaranov vbaranov deleted the vb-contract-reqder-int-fix branch February 12, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants