Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order bridged tokens in descending order by tokens holder for Omni bridge cap calculation #3662

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 25, 2021

Motivation

Tokens with more holders should get the price first from CoinGecko. Requests of the price for other tokens may be rate-limited by CoinGecko.

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Feb 25, 2021

Pull Request Test Coverage Report for Build 2b3b17d06d11739316e44ee0d5b7149d1f3d0920-PR-3662

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.2%) to 64.8%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
Totals Coverage Status
Change from base Build 7e7c8d5db89a2bb8b2a8cfc34b7534d583e9a351: 1.2%
Covered Lines: 2106
Relevant Lines: 3250

💛 - Coveralls

@vbaranov vbaranov merged commit 7de1378 into master Feb 25, 2021
@vbaranov vbaranov deleted the vb-order-bridged-tokens branch February 25, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants