Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table loader fix #3696

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Table loader fix #3696

merged 1 commit into from
Mar 11, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 11, 2021

Motivation

Fix tokens list page table loader: number of columns in loader should match the number of columns in the table

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Mar 11, 2021

Pull Request Test Coverage Report for Build b9848b44a2ca85a5086ffe7c3e56178232298a14-PR-3696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.1%) to 64.643%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
Totals Coverage Status
Change from base Build 429b75e7d9acbdb053421ca3bd9d3d40d67472e2: -1.1%
Covered Lines: 2108
Relevant Lines: 3261

💛 - Coveralls

@vbaranov vbaranov merged commit a8a8a7f into master Mar 11, 2021
@vbaranov vbaranov deleted the vb-table-loader-fix branch March 11, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants