Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ethprice API endpoint #3719

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 19, 2021

Motivation

From Discord:

Hey frens, anyone know what this is showing?
https://blockscout.com/poa/xdai/api?module=stats&action=ethprice

Changelog

Rename ethprice API endpoint to coinprice in order to eliminate confusion

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Mar 19, 2021

Pull Request Test Coverage Report for Build 5b5c4d490bc6617292d45fcda4119bc67c29eb19-PR-3719

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 64.393%

Files with Coverage Reduction New Missed Lines %
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
lib/block_scout_web/checksum_address.ex 6 55.56%
Totals Coverage Status
Change from base Build 80cb87571ec12ee8cbd96ef9461ceec886ea6b90: -0.6%
Covered Lines: 2096
Relevant Lines: 3255

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-rename-ethprice-api-endpoint branch from 6d61117 to 5b5c4d4 Compare March 19, 2021 10:37
@vbaranov vbaranov merged commit 900c36f into master Mar 19, 2021
@vbaranov vbaranov deleted the vb-rename-ethprice-api-endpoint branch March 19, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants