Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token balance on demand fetcher memory leak fix #3735

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 24, 2021

Motivation

Memory leak in Token balance on demand fetcher

Changelog

Re-write Token balance on-demand fetcher as ordinary Module instead of Genserver process

Chore:

  • Fix the issue when rendering of tokens dropdown at address page is called 6 times on the page: use checksummed address in the URI and ignore NaN balance in the state

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Mar 24, 2021

Pull Request Test Coverage Report for Build 9c183f10f32aa14be0a78d1181d0519e0224abae-PR-3735

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.01%) to 64.672%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/address_token_balance_controller.ex 7 58.33%
Totals Coverage Status
Change from base Build 73cde46bb59b20cfb4d23b49d34033e5a81362ab: 2.01%
Covered Lines: 2118
Relevant Lines: 3275

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-token-balance-ondemand-fetcher-memory-leak-fix branch from 9c183f1 to bd70433 Compare March 24, 2021 09:44
@vbaranov vbaranov merged commit 323ddcb into master Mar 24, 2021
@vbaranov vbaranov deleted the vb-token-balance-ondemand-fetcher-memory-leak-fix branch March 24, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants