Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool metadata display/change to Staking DApp #3758

Merged
merged 5 commits into from
Apr 5, 2021

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Apr 1, 2021

Motivation

These changes add pool names and descriptions to Staking UI. Now, if a pool has a name, it will be displayed in lists and popups instead of a short representation of the staking address. Description is displayed in Pool info popup.

Pools can change their names and descriptions through the Pool info popup as it's shown on one of the screens below.

The screenshots:

1

2

3

4

5

Checklist for your Pull Request (PR)

@varasev varasev requested a review from vbaranov April 1, 2021 11:43
@coveralls
Copy link

coveralls commented Apr 1, 2021

Pull Request Test Coverage Report for Build 41ab0a23b46524ea96806a29cc5f952ad5f80613-PR-3758

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.5%) to 64.188%

Totals Coverage Status
Change from base Build 3cc73bf223bbfa7497978b6c6578dc06ca373c95: 9.5%
Covered Lines: 2115
Relevant Lines: 3295

💛 - Coveralls

@varasev varasev changed the title Add pool name and description display to Staking DApp Add pool metadata display/change to Staking DApp Apr 2, 2021
@varasev varasev force-pushed the va-staking-dapp-display-pool-names branch from 41ab0a2 to 189ae5c Compare April 5, 2021 07:59
@vbaranov vbaranov merged commit af77e44 into master Apr 5, 2021
@vbaranov vbaranov deleted the va-staking-dapp-display-pool-names branch April 5, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants