Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Sourcify smart-contract verification: fetch smart contract metadata from Sourcify repo if it has been already verified there #4267

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Extend Sourcify smart-contract verification: fetch smart contract metadata from Sourcify repo if it has been already verified there #4267

merged 1 commit into from
Jun 11, 2021

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Jun 10, 2021 •
edited by vbaranov
Loading

Resolves issue #4155

  • Added functionality to fetch smart-contracts metadata via Sourcify
  • In sourcify.ex: checkByAddresses (deprecated) -> check-by-addresses

@nikitosing nikitosing force-pushed the np-add-sourcify-verification branch from cfa9b06 to ed47f8d Compare June 10, 2021 10:03
@nikitosing nikitosing changed the title Added sourcify verification Added sourcify verification endpoint Jun 10, 2021
@nikitosing nikitosing force-pushed the np-add-sourcify-verification branch 4 times, most recently from 69f8bd9 to d6eed55 Compare June 10, 2021 11:25
@vbaranov vbaranov self-requested a review June 10, 2021 13:51
vbaranov
vbaranov requested changes Jun 10, 2021
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should replace 2nd option which verifies through Sourcify only with 3d option which verifies or fetches metadata from Sourcify

Screenshot 2021-06-10 at 16 51

CHANGELOG.md Outdated Show resolved Hide resolved
apps/block_scout_web/lib/block_scout_web/templates/address_contract_verification/new.html.eex Outdated Show resolved Hide resolved
...ut_web/lib/block_scout_web/templates/address_contract_verification_via_sourcify/new.html.eex Outdated Show resolved Hide resolved
@nikitosing nikitosing changed the title Added sourcify verification endpoint Added sourcify verification Jun 11, 2021
@nikitosing nikitosing force-pushed the np-add-sourcify-verification branch 2 times, most recently from 48a4f87 to 7df7c17 Compare June 11, 2021 03:55
@vbaranov vbaranov changed the title Added sourcify verification Extend verification through [Sourcify](https://sourcify.dev) smart-contract verification: fetch smart contract metadata from Sourcify repo if it has been already verified there Jun 11, 2021
@vbaranov vbaranov changed the title Extend verification through [Sourcify](https://sourcify.dev) smart-contract verification: fetch smart contract metadata from Sourcify repo if it has been already verified there Extend verification through Sourcify smart-contract verification: fetch smart contract metadata from Sourcify repo if it has been already verified there Jun 11, 2021
@vbaranov vbaranov changed the title Extend verification through Sourcify smart-contract verification: fetch smart contract metadata from Sourcify repo if it has been already verified there Extend Sourcify smart-contract verification: fetch smart contract metadata from Sourcify repo if it has been already verified there Jun 11, 2021
@nikitosing nikitosing force-pushed the np-add-sourcify-verification branch from 9315416 to 60245a1 Compare June 11, 2021 10:37
@nikitosing nikitosing force-pushed the np-add-sourcify-verification branch from 60245a1 to f7d4187 Compare June 11, 2021 10:50
@vbaranov vbaranov merged commit 84a8357 into master Jun 11, 2021
@vbaranov vbaranov deleted the np-add-sourcify-verification branch June 11, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikitosing @vbaranov