[4274] Fix/improve search token-autocomplete #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
reviewed
Jun 22, 2021
There was a problem hiding this comment.
@vsyrovat changes look good to me.
mix credo suggests refactoring opportunities:
Refactoring opportunities
┃
┃ [F] ↗ `with` contains only one <- clause and an `else`
┃ branch, use a `case` instead
┃ apps/explorer/lib/explorer/chain.ex:1129 #(Explorer.Chain.search_contract)
┃ [F] ↗ `with` contains only one <- clause and an `else`
┃ branch, use a `case` instead
┃ apps/explorer/lib/explorer/chain.ex:1103 #(Explorer.Chain.search_token)
|
@vbaranov credo suggestions fixed |
vbaranov
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fall on search token-autocomplete by non-latin characters
*Fix search token-autocomplete by multiple words"
This PR fixes #4274
No breaking changes IMHO
I don't know exactly is it possible to tokens be in non-latin characters. @vbaranov please check this point
This PR not fix search by, for example, "лучшие токены" - this search string will be treat as empty string.