Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false pending txs #4360

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Fix false pending txs #4360

merged 1 commit into from
Jul 19, 2021

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Jul 12, 2021

Close #4348

Changelog

Bug Fixes

  • Added else branch in pending_transactions_sanitizer.ex/invalidate_block
  • block_hash and block_number will be assigned to pending txs included in reorg blocks via sanitizer

Checklist for your Pull Request (PR)

@nikitosing nikitosing force-pushed the np-fix-forked-pending-txs branch 4 times, most recently from 29a6ac1 to 262d4ca Compare July 12, 2021 07:35
@nikitosing nikitosing requested a review from vbaranov July 12, 2021 08:20
@nikitosing nikitosing force-pushed the np-fix-forked-pending-txs branch 3 times, most recently from db386e8 to 4398d5d Compare July 19, 2021 12:24
@nikitosing nikitosing requested a review from vbaranov July 19, 2021 12:56
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick regarding method arguments ordering.

apps/indexer/lib/indexer/pending_transactions_sanitizer.ex Outdated Show resolved Hide resolved
@vbaranov vbaranov merged commit 3901c46 into master Jul 19, 2021
@vbaranov vbaranov deleted the np-fix-forked-pending-txs branch July 19, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions included into reorgs are shown as pending
2 participants