Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Erlang/OTP 24 #4704

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Update to Erlang/OTP 24 #4704

merged 1 commit into from
Sep 28, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 28, 2021

Motivation

Update to Erlang/OTP 24

Changelog

  • Erlang/OTP 24 pinned
  • bitwalker/alpine-elixir-phoenix:1.12.2 -> bitwalker/alpine-elixir-phoenix:1.12.3

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-erlang-otp-24 branch 8 times, most recently from d599b51 to a8be8bf Compare September 28, 2021 18:39
@vbaranov vbaranov merged commit 43f9a24 into master Sep 28, 2021
@vbaranov vbaranov deleted the vb-erlang-otp-24 branch September 28, 2021 19:18
@vbaranov vbaranov mentioned this pull request Sep 28, 2021
@@ -1,4 +1,4 @@
FROM bitwalker/alpine-elixir-phoenix:1.12.2
FROM bitwalker/alpine-elixir-phoenix:1.12.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidhujag @vbaranov 1.12.3 has not been released yet. FYI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean @zalam003 it does exist under sidhujag/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidhujag If you search Docker hub, you will see alpine-elixir-phoenix latest is 1.12.2:
https://hub.docker.com/r/bitwalker/alpine-elixir-phoenix/tags?page=1&ordering=last_updated&name=1.12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you search on docker hub under sidhujag you will see 1.12.3 is the latest version, please re-read what I said.

Copy link
Contributor

@zalam003 zalam003 Oct 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really arguing with you @sidhujag. My point was the current version of Dockerfile will not work. We need to either use:

FROM bitwalker/alpine-elixir-phoenix:1.12.2

or

FROM sidhujag/alpine-elixir-phoenix:1.12.3

My recommendation is to use an official version of the container and not use any personal ones. Also we should also not move between providers.

FYI @vbaranov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zalam003 its as official as bitwalker's is. If you go into the github you can see it points to bitwalker's elixir repo for 1.12.3, he has not simply updated the links to point upstream which is the only difference in mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants