-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Erlang/OTP 24 #4704
Update to Erlang/OTP 24 #4704
Conversation
d599b51
to
a8be8bf
Compare
a8be8bf
to
907a473
Compare
@@ -1,4 +1,4 @@ | |||
FROM bitwalker/alpine-elixir-phoenix:1.12.2 | |||
FROM bitwalker/alpine-elixir-phoenix:1.12.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/bitwalker/alpine-elixir-phoenix/blob/master/VERSION or https://hub.docker.com/r/bitwalker/alpine-elixir-phoenix/tags?page=1&ordering=last_updated
Does 1.12.3 exist? you can use sidhujag/ domain if need be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean @zalam003 it does exist under sidhujag/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sidhujag If you search Docker hub, you will see alpine-elixir-phoenix
latest is 1.12.2:
https://hub.docker.com/r/bitwalker/alpine-elixir-phoenix/tags?page=1&ordering=last_updated&name=1.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you search on docker hub under sidhujag you will see 1.12.3 is the latest version, please re-read what I said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really arguing with you @sidhujag. My point was the current version of Dockerfile will not work. We need to either use:
FROM bitwalker/alpine-elixir-phoenix:1.12.2
or
FROM sidhujag/alpine-elixir-phoenix:1.12.3
My recommendation is to use an official version of the container and not use any personal ones. Also we should also not move between providers.
FYI @vbaranov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zalam003 its as official as bitwalker's is. If you go into the github you can see it points to bitwalker's elixir repo for 1.12.3, he has not simply updated the links to point upstream which is the only difference in mine.
Motivation
Update to Erlang/OTP 24
Changelog
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.