Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trimming to the contract functions inputs #4711

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Oct 2, 2021

Close #4709

Changelog

Bug Fixes

  • Added trimming to the contract functions inputs
  • Fixed bug descirbed in issue
  • Added test for prepareMethodArgs function

Checklist for your Pull Request (PR)

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitosing I suggest refactor and cleanup implementation. We already have replaceSpaces function before. Could you elaborate on why it didn't work, as expected? I guess we created this function specifically for this issue, we trying to resolve. And let's place trimming logic into a single function? Also, could we add tests for this issues since it appears the second time?

@nikitosing nikitosing force-pushed the np-fix-contract-inputs-error branch 2 times, most recently from fd5e3de to 7683d76 Compare October 6, 2021 15:34
@vbaranov vbaranov merged commit 0692487 into master Oct 11, 2021
@vbaranov vbaranov deleted the np-fix-contract-inputs-error branch October 11, 2021 08:52
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Oct 11, 2021
…puts-error

Add trimming to the contract functions inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract write page: invalid address if whitespaces in the input data
2 participants