Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract verification fix: check only success creation tx #4717

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 4, 2021

Resolves #4716

Motivation

When Blockscout finds a creation transaction for a contract, it doesn't check the status of the transaction but expects one result in the response. However, multiple failed transactions can presence in the DB at the same time.

Changelog

Add check of the tx status in the query for finding contract creation transaction.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-verify-contract-query-fix branch from e0a5ed9 to ef423b9 Compare October 4, 2021 16:02
@vbaranov vbaranov merged commit 5586497 into master Oct 5, 2021
@vbaranov vbaranov deleted the vb-verify-contract-query-fix branch October 5, 2021 07:20
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Oct 5, 2021
…-query-fix

Contract verification fix: check only success creation tx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract verification: expected at most one result but got 6 in query
1 participant