Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 8545 as default port everywhere except Ganache JSON RPC variant #5190

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 14, 2022

Motivation

  • port 7545 is used in some configs except Ganache as a default
  • geth JSON RPC variant doesn't have a fallback to http://localhost:8545 in dev mode

Changelog

  • Set 8545 as default port everywhere except Ganache JSON RPC variant
  • Add a fallback http://localhost:8545 RPC endpoint for geth JSON RPC variant in dev mode

Checklist for your Pull Request (PR)

@vbaranov vbaranov merged commit d093b94 into master Feb 14, 2022
@vbaranov vbaranov deleted the vb-8545-as-default-port branch February 14, 2022 14:56
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Feb 14, 2022
…-port

Set 8545 as default port everywhere except Ganache JSON RPC variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant