Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify native token symbol #5287

Merged
merged 6 commits into from
Mar 9, 2022
Merged

Conversation

zjb0807
Copy link
Contributor

@zjb0807 zjb0807 commented Mar 9, 2022

Use COIN to modify the native token symbol.

@vbaranov vbaranov self-requested a review March 9, 2022 09:57
@vbaranov vbaranov self-requested a review March 9, 2022 11:43
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zjb0807 make start gives me '$COIN' instead of coin name

Screenshot 2022-03-09 at 14 42 54

@vbaranov
Copy link
Member

vbaranov commented Mar 9, 2022

@zjb0807 what do you think on this implementation https://github.com/blockscout/blockscout/pull/3814/files ?

@zjb0807
Copy link
Contributor Author

zjb0807 commented Mar 9, 2022

@zjb0807 what do you think on this implementation https://github.com/blockscout/blockscout/pull/3814/files ?

Our purpose is the same. but my code is more concise.

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@vbaranov vbaranov merged commit 020a99e into blockscout:master Mar 9, 2022
@vbaranov vbaranov mentioned this pull request Mar 9, 2022
6 tasks
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants