Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize token name and symbol before insert into DB, display in the application #5567

Merged
merged 1 commit into from
May 17, 2022

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 17, 2022

Motivation

Token name & symbol are not sanitized before insert into DB and in some pages before display.

Changelog

  • Escape HTML before inserting token name and symbol into DB
  • Escape HTML for token name and symbol in
    • search results page
    • search autocomplete dropdown
    • Blockscout API docs page try section RPC responses

Covered with missing tests.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-safe-token-metadata branch 2 times, most recently from ad7f886 to b89deec Compare May 17, 2022 15:39
@vbaranov vbaranov merged commit 533549b into master May 17, 2022
@vbaranov vbaranov deleted the vb-safe-token-metadata branch May 17, 2022 17:30
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant